Bugfix: Lag when moving nodes. #420
Open
+241
−181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translate camera, when curve or node is near the edge of viewport.
Could translate the camera even if node was not under mouse focus. Also, added tiny delay before moving.
When moving node widget for routine, camera would move, but node would stay in place until the mouse is move manually to trigger touch dragged event.
Member
|
Can you explain why you made the changes you made to try to solve this issue? |
Contributor
Author
|
Changes on EmptyWindow and NodeWidget are mainly the part, that is related to solution. The other other changes, such as moving logic from routine app to nodebaord was done to keep app cleaner and move logic to were it belongs, which also made my work easier while fixing this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving node widget for routine, camera would move, but node would stay in place until the mouse is move manually to trigger touch dragged event.